Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name to ng-data-table #320

Closed
mmrath opened this issue Nov 28, 2016 · 9 comments
Closed

Change name to ng-data-table #320

mmrath opened this issue Nov 28, 2016 · 9 comments

Comments

@mmrath
Copy link
Contributor

mmrath commented Nov 28, 2016

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[*] feature request
[ ] support request => Please do not submit support request here

Now that angular is following semver, I think we will soon have angular 3. It would nice to rename this project to ng-data-table or something on that line. I know this is a breaking change, but nice to do it earlier.

@amcdnl
Copy link
Contributor

amcdnl commented Nov 28, 2016

ng-data-table is a anti pattern name since it starts with ng...generally that's reserved for angular framework names.

On the flip side, @Brocco told me that there is some AoT issues with a single name directive so it does need to change, I just don't know what I want to change it to.

@mmrath
Copy link
Contributor Author

mmrath commented Nov 28, 2016

May be something like sm-data-table or sl-data-table?

@amcdnl
Copy link
Contributor

amcdnl commented Nov 28, 2016

Ya, I was thinking swui-data-table or swui-datatable playing off https://github.com/swimlane/swui

@mmrath
Copy link
Contributor Author

mmrath commented Nov 28, 2016

May be just SW instead of SWUI. Just a personal preference for shorter code.

@Brocco
Copy link
Contributor

Brocco commented Nov 29, 2016

I completely agree with the idea of renaming the lib. My suggestion for names in no particular order:

  • swui-data-table
  • swui-datatable
  • sl-data-table
  • sl-datatable
  • swui-grid
  • sl-grid
  • panda-grid

@elvisbegovic
Copy link
Contributor

elvisbegovic commented Nov 29, 2016

Panda-grid is my favorite because simple to remember as ag-grid and really attrayant !

@amcdnl
Copy link
Contributor

amcdnl commented Nov 29, 2016

Prob gonna do swui-datatable ... ppl gonna hate me for changing this haha

@Brocco
Copy link
Contributor

Brocco commented Nov 29, 2016

You can leave both there for a while by specifying both selectors, but announce the change and planned deprecation.

@amcdnl
Copy link
Contributor

amcdnl commented Dec 1, 2016

Fixed in master, will be released soon.

@amcdnl amcdnl closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants