-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name to ng-data-table #320
Comments
ng-data-table is a anti pattern name since it starts with ng...generally that's reserved for angular framework names. On the flip side, @Brocco told me that there is some AoT issues with a single name directive so it does need to change, I just don't know what I want to change it to. |
May be something like sm-data-table or sl-data-table? |
Ya, I was thinking |
May be just SW instead of SWUI. Just a personal preference for shorter code. |
I completely agree with the idea of renaming the lib. My suggestion for names in no particular order:
|
Panda-grid is my favorite because simple to remember as ag-grid and really attrayant ! |
Prob gonna do |
You can leave both there for a while by specifying both selectors, but announce the change and planned deprecation. |
Fixed in master, will be released soon. |
I'm submitting a ... (check one with "x")
Now that angular is following semver, I think we will soon have angular 3. It would nice to rename this project to ng-data-table or something on that line. I know this is a breaking change, but nice to do it earlier.
The text was updated successfully, but these errors were encountered: