-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table calls sortInternalRows with externalSorting=true #1470
Comments
How i can workaround for fix this issue @dmartinzar |
@dmartinzar, @ronsc . I have same issue. Anyone fixed it? |
We have the same issue in our application. I can confirm that downgrading the dependency to 11.2.0 (bug was introduced in 11.3.0) fixes the issue. Can somebody take a look at this? Do you accept PRs on that? |
As nobody from the ngx-datatable seems to answer this issue, I downgraded the package to 11.2.0. However, I quickly discovered that this creates another bug in my app. The fix for it was merged in 13.0.1: #1375 Moreover, in our case the sorting issue exists even with Therefore, I came up with the workaround - define a Noop comparator like so:
This looks bad, but fixes the issue, allowing us to use the latest version. We can remove rxjs-compat now by the way. 👍 I hope this helps @dmartinzar @ronsc @lecongbang90! |
This issue also affects |
I have the same issue. Are there any plans now to fix it someday? |
I'm submitting a ... (check one with "x")
Current behavior
When
externalSorting
is enabled, thesortInternalRows()
method is still called due to this commit: 67a4e8a This causes the rows to change their sort order in undesirable ways after they are passed to the datatable component. Single sorting seems to work fine, but when combined with[sortType]="'multi'"
the sort order is incorrect.I believe the additional call to
sortInternalRows()
added to thetranslateColumns()
method should be changed to:Expected behavior
Multi sorting would work correctly with
externalSorting=true
and the grid would never attempt to sort the rows itself.Reproduction of the problem
Turn on
[externalSorting]="true"
and[sortType]="'multi'"
and see that thesortInternalRows()
method is called.Please tell us about your environment:
The text was updated successfully, but these errors were encountered: