-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodata when reset rows[] object #136
Comments
Can you build a demo w/ plunkr? |
I can't, I have so many module but I have only one datatable tag and his rows[] is different... but when scrolling it wont works with another rows[] update ... very strange when I reset rows[] how can I reset height too |
I'm sorry w/o a demo, I won't be able to help. |
@amcdnl hmm? Close my issue like this isn't cool. this takes me 2hours to find how to reproduce but here you are: http://plnkr.co/edit/k7JBaZottJUhtOdgfW1P?p=preview your help is welcome ! so when you click The problem is when you click Get data 1 (scroll a little bit down...) THEN click Get data 2 => SURPRISE ! No data or data aren't reset if you were scrolled before FACULTATIF: do you have idea how can I hide header and emptyMessage "No data ti display" when waiting data from server... |
Awesome, I will check it out today! Sorry, I closed it but without proper reproduction I can't make a fix ;). |
I noticed same issue while trying to get around https://github.com/swimlane/angular2-data-table/issues/127 I was delaying the the setting of the rows object bound to the datatable in ngAfterViewInit() to see if this worked, but it didn't I got message 'No data Loaded'. |
Is this resolved by the other PR? |
@amcdnl I posted a plunker, do you checked it ? http://plnkr.co/edit/k7JBaZottJUhtOdgfW1P?p=preview The problem is always here on my plunker with last RP. 1.But today I have another problem: you can check it here on my GIF, you will see the content of the table is fill only until middle ... not completly... maybe because of "display:none" nefore data is available.... the problem is here: 2.Another things or ENHANCEMENT please put the scroll bar in TOP:0 when we change data... you can see on this next gif that if I scroll bottom and change TAB so the scrollbar keep same position instead of going TOP !!! Paging is always same ... how fix this ? |
Ya, agreed I think it should reset scrollbar position to the top on a re-sort. |
@amcdnl What do you mean "re-sort" Because I just reset data I don't sort them on clicking on column, I think the scrollbar need go position to top when this is changing: [rows]='dataFiles' And what you think about my first problem called MIDDLE EMPTY PROBLEM ? |
Fixed the sort not updating scrollbar in 0.7.4, See if that fixes this plz. |
@amcdnl my friend please apologize but not fixed! I have one more same question do you checked my demo here http://plnkr.co/edit/k7JBaZottJUhtOdgfW1P?p=preview |
Is this still happening? |
donno can't retry now but will close it and reopen it if still happen, thanks |
it still happens. if i show 10 rows per page and go on page 2, then change the table.bodyHeight (table height via css) the scroll is at top but first 10 rows space is blank and the second part is visible. It shows the data on scroll down, because scroll up is not possible. If it is done from page 1 there is no such problem. |
BUG:
This component works well when no scroll but when I scroll and change rows[] data with ajax call no data are displayed, here you are: click this gif
The is one for all tab, I juste reset rows data. How can achieve this bug ? Is there better way to update datarows or?
FACULTATIF: you can see when waiting data I set
rows=[]
empty and I have header and emptyMessage "No data to display" instead of nothing... I don't think I can use something like style display:hide whenrows.length==0
The text was updated successfully, but these errors were encountered: