Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redacted modifier #232

Merged
merged 3 commits into from
Aug 1, 2020
Merged

Add redacted modifier #232

merged 3 commits into from
Aug 1, 2020

Conversation

carson-katri
Copy link
Member

This adds redacted(reason:) and RedactionReason. Currently, only Text is redacted, and this is done by covering the text with a grey ::after element.

@carson-katri carson-katri added the SwiftUI compatibility Tokamak API differences with SwiftUI label Aug 1, 2020
@MaxDesiatov MaxDesiatov changed the base branch from main to static-renderer August 1, 2020 10:31
Base automatically changed from static-renderer to main August 1, 2020 20:27
@MaxDesiatov
Copy link
Collaborator

I guess macos_build is failing because GitHub Actions is still on Xcode 12 beta 2

MaxDesiatov
MaxDesiatov approved these changes Aug 1, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@carson-katri carson-katri merged commit 70d31b2 into main Aug 1, 2020
@carson-katri carson-katri deleted the redacted branch August 1, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carson-katri @MaxDesiatov @j-f1