-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make reconciler tests build and run on macOS #229
Conversation
I wasn’t able to build the combine fork on Arch Linux either. Maybe use OpenCombine/OpenCombine instead of the fork for Linux? Unless that’s only a problem on Arch, which I don’t know for sure. It’s the same error I get on macOS. |
No, I don't think my fork can be built on non-WASI platforms, I had a few things from |
dependencies: [.product( | ||
name: "OpenCombine", | ||
package: "OpenCombine", | ||
condition: .when(platforms: [.wasi, .linux]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you swap out the OpenCombine
url in .package
on line 34 when on Linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, at least after looking at the proposal. I'll try to submit my changes to the upstream OpenCombine repo to make it work on all platforms including WASI, I just have another old open PR there with the zip
implementation that I need to finish first...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass after linking the wasm version into ~/.swiftenv/versions
and running swift test
Yeah, that builds and runs on macOS though unless you pass the |
We can't run our basic reconciler tests in a WASI environment yet because
XCTestExpectation
is not available on WASI as it relies on the presence ofDispatch
. We can run these tests on macOS though, and even on Linux in the future when Swift 5.3 is available for Linux on GitHub Actions.My current OpenCombine fork doesn't build on macOS and it was much easier to add a new
CombineShim
module that uses native Combine there.