Allow modified views to fill their parent if a child requires it #165
+79
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 8ab706a |
MaxDesiatov
reviewed
Jul 7, 2020
| @@ -79,6 +79,7 @@ private extension EdgeInsets { | |||
| } | |||
|
|
|||
| extension _PaddingLayout: DOMViewModifier { | |||
| public var orderDependent: Bool { true } | |||
There was a problem hiding this comment.
nit
Suggested change
| public var orderDependent: Bool { true } | |
| public var isOrderDependent: Bool { true } |
MaxDesiatov
reviewed
Jul 7, 2020
| @@ -19,6 +19,12 @@ public typealias ModifiedContent = TokamakCore.ModifiedContent | |||
|
|
|||
| public protocol DOMViewModifier { | |||
| var attributes: [String: String] { get } | |||
| /// Can the modifier be flattened? | |||
| var orderDependent: Bool { get } | |||
There was a problem hiding this comment.
Suggested change
| var orderDependent: Bool { get } | |
| var isOrderDependent: Bool { get } |
MaxDesiatov
reviewed
Jul 7, 2020
| } | ||
|
|
||
| extension DOMViewModifier { | ||
| public var orderDependent: Bool { false } |
There was a problem hiding this comment.
Suggested change
| public var orderDependent: Bool { false } | |
| public var isOrderDependent: Bool { false } |
MaxDesiatov
reviewed
Jul 7, 2020
| @@ -42,6 +48,7 @@ extension _ZIndexModifier: DOMViewModifier { | |||
| } | |||
|
|
|||
| extension _BackgroundModifier: DOMViewModifier where Background == Color { | |||
| public var orderDependent: Bool { true } | |||
There was a problem hiding this comment.
Suggested change
| public var orderDependent: Bool { true } | |
| public var isOrderDependent: Bool { true } |
MaxDesiatov
reviewed
Jul 7, 2020
| content | ||
| }) | ||
| if let adjacentModifier = content as? AnyModifiedContent, | ||
| !(adjacentModifier.anyModifier.orderDependent || domModifier.orderDependent) { |
There was a problem hiding this comment.
Suggested change
| !(adjacentModifier.anyModifier.orderDependent || domModifier.orderDependent) { | |
| !(adjacentModifier.anyModifier.isOrderDependent || domModifier.isOrderDependent) { |
MaxDesiatov
reviewed
Jul 7, 2020
| @@ -32,6 +32,7 @@ extension _OverlayModifier: DOMViewModifier where Overlay == _ShapeView<_Stroked | |||
|
|
|||
| // TODO: Implement arbitrary clip paths with CSS `clip-path` | |||
| extension _ClipEffect: DOMViewModifier { | |||
| public var orderDependent: Bool { true } | |||
There was a problem hiding this comment.
Suggested change
| public var orderDependent: Bool { true } | |
| public var isOrderDependent: Bool { true } |
MaxDesiatov
reviewed
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, a
ModifiedContentview wrapping aVStackwith aSpacerwill allow the stack to fill the parent's height by puttingheight: 100%;on itself. This goes for all views that have a childSpacerContainerthat fills either axis.