Add AppearanceActionModifier, onAppear/onDisappear #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Jul 2, 2020
| @@ -29,6 +29,8 @@ public struct Counter: View { | |||
| Button("Increment") { count += 1 } | |||
| Text("\(count)") | |||
| } | |||
| .onAppear { print("Counter.VStack onAppear") } | |||
| .onDisappear { print("Counter.VStack onDisappear") } | |||
There was a problem hiding this comment.
Where do print statements get outputted?
There was a problem hiding this comment.
In Web Inspector console, all print output is redirected with console.log.
j-f1
previously approved these changes
Jul 2, 2020
carson-katri
reviewed
Jul 2, 2020
carson-katri
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to unblock #136 as I think it would make sense for the
DOMEnvironmentview there to add/remove its color scheme listener inonAppear/onDisappearclosures.I've also restored full SwiftUI compatibility in the signature of
func modifier<Modifier>(_ modifier: Modifier). ConsequentlyViewDeferredToRendererhad to be implemented onModifiedContentthen instead of_ViewModifier_Contentto make it work.