Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link #617

Closed
linajandren opened this issue Nov 1, 2022 · 5 comments · Fixed by #652
Closed

Broken link #617

linajandren opened this issue Nov 1, 2022 · 5 comments · Fixed by #652
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors

Comments

@linajandren
Copy link

The link for matplotlib.pyplot near the top of the page is broken. The link points to https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.html#module-matplotlib.pyplot but this gives me a page not found error. I'm not certain where the link should point, perhaps https://matplotlib.org/stable/tutorials/introductory/pyplot.html ?

@alee alee added help wanted Looking for Contributors good first issue Good issue for first-time contributors labels Nov 1, 2022
@alee
Copy link
Member

alee commented Nov 1, 2022

Thanks for letting us know! I think the link in Episode 9 (http://swcarpentry.github.io/python-novice-gapminder/09-plotting/index.html) used to go to a page like this: https://matplotlib.org/3.5.3/api/_as_gen/matplotlib.pyplot.html but I prefer your link as a more durable URL that provides a nicer overview of matplotlib as opposed to an API landing page 😅 .

We'd welcome a PR to correct the link in episode 9, it'd be good to adjust all of those similar links if possible. I counted at least 4 of them there from a cursory grep. That matplotlib page is linked twice, once early on in the summary and again when introducing plotting via pandas dataframes, probably that second one could go away..?

@vhmcck
Copy link

vhmcck commented Nov 21, 2022

Hi @alee, I recently completed my Instructor Training and I am looking for issues that need to be fixed. Do you still need a hand with this? If I understand correctly, the PR would have updated links. Any other than the three discussed (matplotlib, tick_params, savefig)?

@alee
Copy link
Member

alee commented Nov 21, 2022

Absolutely, I don't believe anyone else has put forward a PR or indicated they are up for working on this. Thanks @vhmcck !

@vhmcck
Copy link

vhmcck commented Nov 22, 2022

Thanks, @alee! I will go through the links and update them as necessary. I will let you know when I have submitted the PR with these changes.

@vhmcck
Copy link

vhmcck commented Nov 30, 2022

Hi @alee,
Just submitted a PR with my attempt at the second draft. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants