Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): typeof class should be function #9522

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

CPunisher
Copy link
Contributor

Description:

BREAKING CHANGE:

Related issue (if exists):

closes #9453

@CPunisher CPunisher requested a review from a team as a code owner September 2, 2024 13:51
Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 9026d4e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #9522 will not alter performance

Comparing CPunisher:fix/typeof-class (9026d4e) with main (5fd68f9)

Summary

✅ 178 untouched benchmarks

@Austaras
Copy link
Member

Austaras commented Sep 2, 2024

Could you add some tests in crates/swc_ecma_minifier/tests/fixture/issues?

@kdy1 kdy1 added this to the Planned milestone Sep 2, 2024
Austaras
Austaras previously approved these changes Sep 3, 2024
magic-akari
magic-akari previously approved these changes Sep 3, 2024
@kdy1 kdy1 dismissed stale reviews from magic-akari and Austaras via 67674ee September 3, 2024 07:31
@kdy1 kdy1 requested a review from a team as a code owner September 3, 2024 07:31
@kdy1 kdy1 enabled auto-merge (squash) September 3, 2024 07:34
@kdy1 kdy1 changed the title fix(es/minifier): typeof class should be function rather than object fix(es/minifier): typeof class should be function Sep 3, 2024
@kdy1 kdy1 merged commit c7fdd6b into swc-project:main Sep 3, 2024
154 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.24 Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

minifier: typeof <class> should be evaluated as "function", not "object"
4 participants