Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Require newer version of allocator #9386

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

crawford
Copy link
Contributor

@crawford crawford commented Aug 6, 2024

EqIgnoreSpan uses the nightly_only macro, which was introduced in version 0.1.7 of swc_allocator. When building with the older version of the allocator, the following error results:

error[E0432]: unresolved import `swc_allocator::nightly_only`
 --> /home/user/.cargo/registry/.../swc_common-0.36.3/src/eq.rs:4:5
  |
4 | use swc_allocator::nightly_only;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `nightly_only` in the root

EqIgnoreSpan uses the nightly_only macro, which was introduced in
version 0.1.7 of swc_allocator. When building with the older version
of the allocator, the following error results:

    error[E0432]: unresolved import `swc_allocator::nightly_only`
     --> /home/user/.cargo/registry/.../swc_common-0.36.3/src/eq.rs:4:5
      |
    4 | use swc_allocator::nightly_only;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `nightly_only` in the root
@crawford crawford requested a review from a team as a code owner August 6, 2024 20:54
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: 8485bd1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #9386 will degrade performances by 6.13%

Comparing crawford:allocator-version (8485bd1) with main (a538ca1)

Summary

❌ 4 regressions
✅ 174 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main crawford:allocator-version Change
es/visitor/base-perf/boxing_boxed 3.1 µs 3.2 µs -4.52%
es/visitor/base-perf/boxing_boxed_clone 2.2 µs 2.4 µs -6.13%
es/visitor/base-perf/boxing_unboxed 3.3 µs 3.4 µs -3.41%
es/visitor/base-perf/boxing_unboxed_clone 2.5 µs 2.6 µs -3.4%

@kdy1 kdy1 merged commit 4e854c7 into swc-project:main Aug 7, 2024
24 checks passed
@kdy1 kdy1 added this to the Planned milestone Aug 7, 2024
@crawford crawford deleted the allocator-version branch August 7, 2024 03:00
@kdy1 kdy1 modified the milestones: Planned, v1.7.8 Aug 7, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants