Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(contributing): Add warning for test --all #9338

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

zrosenbauer
Copy link
Contributor

Description:

BREAKING CHANGE:

Related issue (if exists):

@zrosenbauer zrosenbauer requested a review from a team as a code owner July 28, 2024 22:51
Copy link

changeset-bot bot commented Jul 28, 2024

⚠️ No Changeset found

Latest commit: 3de6dc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codspeed-hq bot commented Jul 29, 2024

CodSpeed Performance Report

Merging #9338 will improve performances by 5.93%

Comparing zrosenbauer:docs/contrib-tests-tip (3de6dc3) with main (acb3952)

Summary

⚡ 4 improvements
✅ 174 untouched benchmarks

Benchmarks breakdown

Benchmark main zrosenbauer:docs/contrib-tests-tip Change
es/visitor/base-perf/boxing_boxed 3.2 µs 3.1 µs +3.8%
es/visitor/base-perf/boxing_boxed_clone 2.4 µs 2.3 µs +3.87%
es/visitor/base-perf/boxing_unboxed 3.4 µs 3.3 µs +4.48%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.5 µs +5.93%

@kdy1 kdy1 added this to the Planned milestone Jul 29, 2024
@kdy1 kdy1 changed the title docs: add warning for test all being nonstandard doc(contributing): Add warning for test --all Jul 29, 2024
@kdy1 kdy1 merged commit 234bb97 into swc-project:main Jul 29, 2024
155 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.4 Jul 31, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 31, 2024
@zrosenbauer zrosenbauer deleted the docs/contrib-tests-tip branch September 9, 2024 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants