Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote_ident inproperly references DUMMY_SP #9299

Closed
levi-nz opened this issue Jul 20, 2024 · 1 comment · Fixed by #9309
Closed

quote_ident inproperly references DUMMY_SP #9299

levi-nz opened this issue Jul 20, 2024 · 1 comment · Fixed by #9309
Assignees
Labels
Milestone

Comments

@levi-nz
Copy link
Contributor

levi-nz commented Jul 20, 2024

Describe the bug

quote_ident incorrectly references DUMMY_SP if ctxt and expr are provided in arguments, meaning external callers cannot call this macro. It should use $crate::swc_common::DUMMY_SP instead.

$crate::swc_ecma_ast::Ident::new(sym, DUMMY_SP, $ctxt);

Input code

No response

Config

No response

Playground link (or link to the minimal reproduction)

https://play.swc.rs

SWC Info output

No response

Expected behavior

N/A

Actual behavior

No response

Version

1.7.0

Additional context

No response

@levi-nz levi-nz added the C-bug label Jul 20, 2024
@kdy1 kdy1 self-assigned this Jul 20, 2024
@kdy1 kdy1 added this to the Planned milestone Jul 20, 2024
@kdy1 kdy1 closed this as completed in bdaaf47 Jul 22, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 23, 2024
@swc-bot
Copy link
Collaborator

swc-bot commented Aug 22, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants