Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Handle class fields correctly #8835

Merged
merged 6 commits into from
Apr 11, 2024
Merged

fix(es/compat): Handle class fields correctly #8835

merged 6 commits into from
Apr 11, 2024

Conversation

magic-akari
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3b03ab0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@magic-akari magic-akari marked this pull request as ready for review April 9, 2024 14:31
@magic-akari magic-akari requested a review from a team as a code owner April 9, 2024 14:31
kdy1
kdy1 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 added this to the Planned milestone Apr 10, 2024
@kdy1 kdy1 enabled auto-merge (squash) April 10, 2024 23:12
swc-bot
swc-bot reviewed Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 5cc585b into swc-project:main Apr 11, 2024
142 checks passed
@magic-akari magic-akari deleted the fix/issue-8830 branch April 12, 2024 02:41
@kdy1 kdy1 modified the milestones: Planned, 1.4.14 Apr 15, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@Austaras Austaras Austaras approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.4.14
Development

Successfully merging this pull request may close these issues.

useDefineForClassFields: false can set members in wrong constructor
4 participants
@magic-akari @Austaras @kdy1 @swc-bot