Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Remove wlr_output_layout_move or remove error loging in wlr_output_layout_move #1083

Open
VincentVanlaer opened this issue Jun 24, 2018 · 0 comments

Comments

@VincentVanlaer
Copy link
Contributor

VincentVanlaer commented Jun 24, 2018

wlr_output_layout_add can also move outputs. The only difference between move and add is that move will error when the output is not in the layout. This function is only useful if a compositor does not track whether an output is in the layout and still has ways to move it at runtime. If we want to keep wlr_output_layout_move, then we should remove the error at https://github.com/swaywm/wlroots/blob/master/types/wlr_output_layout.c#L283. In order to avoid the error the compositor needs to know if the output is in the layout or not, which defeats the purpose of wlr_output_layout_move.


wlroots has migrated to gitlab.freedesktop.org. This issue has been moved to:

https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/1083

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant