From 5e405ddebb2f08e4d3aa4b230a02d325db4aaca5 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 19 Mar 2014 11:08:13 +1100 Subject: [PATCH] percpu-add-preemption-checks-to-__this_cpu-ops-fix-checkpatch-fixes WARNING: storage class should be at the beginning of the declaration #25: FILE: lib/smp_processor_id.c:10: +notrace static unsigned int check_preemption_disabled(const char *what1, WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... #36: FILE: lib/smp_processor_id.c:42: + printk(KERN_ERR "BUG: using %s%s() in preemptible [%08x] code: %s/%d\n", ERROR: space required after that ',' (ctx:VxV) #46: FILE: lib/smp_processor_id.c:56: + return check_preemption_disabled("smp_processor_id",""); ^ total: 1 errors, 2 warnings, 36 lines checked ./patches/percpu-add-preemption-checks-to-__this_cpu-ops-fix.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Christoph Lameter Signed-off-by: Andrew Morton --- lib/smp_processor_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/smp_processor_id.c b/lib/smp_processor_id.c index d12d2d60ff6e42..1afec32de6f21c 100644 --- a/lib/smp_processor_id.c +++ b/lib/smp_processor_id.c @@ -53,7 +53,7 @@ notrace static unsigned int check_preemption_disabled(const char *what1, notrace unsigned int debug_smp_processor_id(void) { - return check_preemption_disabled("smp_processor_id",""); + return check_preemption_disabled("smp_processor_id", ""); } EXPORT_SYMBOL(debug_smp_processor_id);