Fixed issue with update_positions that wasn't taking 'scope_condition' into account #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion' into account
|
Thanks for fixing this! |
swanandp
added a commit
that referenced
this pull request
Aug 9, 2012
Fixed issue with update_positions that wasn't taking 'scope_condition' into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as you would have more than one list, items positions would be updated twice when calling insert_at. The 'update_positions' callback would check if there are more than one page at the new position, and if there was would update the intermediate items. Problem being that this check didn't take the scope into account.
I've fixed the issue and added a test case.