Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :add_new_at option #30

Merged
merged 2 commits into from
Mar 29, 2012
Merged

Conversation

mjbellantoni
Copy link
Contributor

Introduce the :add_new_at option that allows the caller to choose if objects will be added to the top or the bottom of the list. Add tests.

Matthew Bellantoni added 2 commits March 5, 2012 22:16
@swanandp swanandp merged commit 2eac0f9 into brendon:master Mar 29, 2012
@swanandp
Copy link
Contributor

Pulled, thanks!

@mjbellantoni
Copy link
Contributor Author

Thanks! When do you think you'll be cutting a new gem?

-m


From: Swanand Pagnis reply@reply.github.com
To: Matthew Bellantoni mjbellantoni@yahoo.com
Sent: Thursday, March 29, 2012 3:06 AM
Subject: Re: [acts_as_list] Add :add_new_at option (#30)

Pulled, thanks!


Reply to this email directly or view it on GitHub:
#30 (comment)

@swanandp
Copy link
Contributor

I want to resolve #31 before pushing a new gem. I think a design mistake was made when the before_create callback was converted into a before_validate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants