Handle case of empty GOROOT (#1798)

evan-goode · web-flow · commit 4c2f8dd452dc · 2024-04-21T23:20:45.000+03:00
In some situations, such as when using the go-swag Nix package, runtime.GOROOT() will be empty, and RangeFiles will skip all source paths since technically, all paths are prefixed with the empty string. See also NixOS/nixpkgs#224701 May resolve some cases of #1622.
diff --git a/packages.go b/packages.go
@@ -93,7 +93,7 @@ func (pkgDefs *PackagesDefinitions) RangeFiles(handle func(info *AstFileInfo) er
 	for _, info := range pkgDefs.files {
 		// ignore package path prefix with 'vendor' or $GOROOT,
 		// because the router info of api will not be included these files.
-		if strings.HasPrefix(info.PackagePath, "vendor") || strings.HasPrefix(info.Path, runtime.GOROOT()) {
+		if strings.HasPrefix(info.PackagePath, "vendor") || (runtime.GOROOT() != "" && strings.HasPrefix(info.Path, runtime.GOROOT())) {
 			continue
 		}
 		sortedFiles = append(sortedFiles, info)

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ func (pkgDefs PackagesDefinitions) RangeFiles(handle func(info AstFileInfo) er`
`93`	`93`	`for _, info := range pkgDefs.files {`
`94`	`94`	`// ignore package path prefix with 'vendor' or $GOROOT,`
`95`	`95`	`// because the router info of api will not be included these files.`
`96`		`- if strings.HasPrefix(info.PackagePath, "vendor") \|\| strings.HasPrefix(info.Path, runtime.GOROOT()) {`
	`96`	`+ if strings.HasPrefix(info.PackagePath, "vendor") \|\| (runtime.GOROOT() != "" && strings.HasPrefix(info.Path, runtime.GOROOT())) {`
`97`	`97`	`continue`
`98`	`98`	`}`
`99`	`99`	`sortedFiles = append(sortedFiles, info)`