Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file mapping in Typescript generators #4715

Open
wing328 opened this issue Feb 5, 2017 · 0 comments
Open

file mapping in Typescript generators #4715

wing328 opened this issue Feb 5, 2017 · 0 comments
Labels
Client: TypeScript Issue: Non-operational
Milestone
Future

Comments

@wing328
Copy link
Contributor

wing328 commented Feb 5, 2017

Description

As discovered by @TiFu TS generators do not have a consistent mapping for file at the moment:

The issue you noticed is caused by the typemapping from file => Buffer. This mapping was added to TypeScriptNodeCodegen.java almost a year ago. Somehow the ts node tests still contain the previous any type mapping defined in AbstractTypeScriptCodegen.java.
Another thing I noticed is, that TypeScriptNodeCodegen uses typeMapping.put("file", "Buffer");, whereas AbstratcTypeScriptCodegen uses typeMapping.put("File", "any"); (note the capitalization of file)

Ref: #4264 (comment)

Swagger-codegen version

2.3.0

Related issues

#4264 (comment)

Suggest a Fix

We'll need to review and fix the mapping for file

cc @Vrolijkx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client: TypeScript Issue: Non-operational
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@wing328