Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] open links inside the app with your main browser #346

Closed
BluePixel4k opened this issue Jan 4, 2024 · 8 comments · Fixed by #407
Closed

[Feature Request] open links inside the app with your main browser #346

BluePixel4k opened this issue Jan 4, 2024 · 8 comments · Fixed by #407
Labels
feature New feature or request

Comments

@BluePixel4k
Copy link

Possibility to open links directly inside the León app via the CustomTabsIntent function.
Chromium and Gecko based browser supporting this.

Benefit: the links get open faster, because not the full browser has to be loaded.

Information about this function:
https://developer.android.com/reference/kotlin/androidx/browser/customtabs/CustomTabsIntent

And an example code from another application:
bubelov/news@38baca3

Thx in advance! :)

@svenjacobs
Copy link
Owner

Interestingly Leon had this feature which was called "Verify", which however was removed in this PR to solve this issue.

So what do we do know? 🤔

@svenjacobs svenjacobs added the feature New feature or request label Jan 5, 2024
@BluePixel4k
Copy link
Author

Oh okay.
Maybe you can add this feature again as an option via something like this (Open URL via custom tab):

@svenjacobs
Copy link
Owner

That's a good idea. I will probably add another switch "Open URL via custom tab" (instead of a new Action option) which generally works for the open button and the "Action after clean".

@BluePixel4k
Copy link
Author

That would be awesome, thank you!

@BluePixel4k
Copy link
Author

@svenjacobs any news on this? :)

@svenjacobs
Copy link
Owner

@BluePixel4k Unfortunately I didn't find much time in the last months to work on Leon 😞 Hopefully soon! 🤞🏼

@svenjacobs
Copy link
Owner

This has been implemented in #407 and will be available with the next release.

@BluePixel4k
Copy link
Author

Awesome, thank you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants