Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ?fbclid= #20

Closed
jimcarst opened this issue Jun 12, 2021 · 3 comments · Fixed by #21 or #23
Closed

Add ?fbclid= #20

jimcarst opened this issue Jun 12, 2021 · 3 comments · Fixed by #21 or #23
Assignees
@svenjacobs
Labels
feature New feature or request
Milestone
0.5

Comments

@jimcarst
Copy link

Hi!
Awesome idea for an app.

I tested a link that contained a tracker that started with ?fbclid=, and it was not recognised.

Cheers!
@svenjacobs svenjacobs self-assigned this Jun 13, 2021
@svenjacobs svenjacobs added this to the 0.5 milestone Jun 13, 2021
@svenjacobs
Copy link
Owner

Hi Jim, thanks for your feedback! I will add this parameter to the Facebook sanitizer.

@svenjacobs svenjacobs added the feature New feature or request label Jun 13, 2021
@svenjacobs svenjacobs linked a pull request Jun 13, 2021 that will close this issue
Add fbclid parameter to Facebook sanitizer #21
Merged
@svenjacobs svenjacobs mentioned this issue Jun 13, 2021
Merged
@svenjacobs
Copy link
Owner

This has been added to version 0.5.0. The update should be available on Google Play soon and on F-Droid in a few days.

@svenjacobs
Copy link
Owner

Unfortunately I forgot to add a database migration to 0.5.0. Should the app crash immediately after startup, please just delete app data and everything should be fine. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svenjacobs svenjacobs

Labels
feature New feature or request
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Add fbclid parameter to Facebook sanitizer svenjacobs/leon
Release 0.5.0 svenjacobs/leon
2 participants
@svenjacobs @jimcarst