Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Radio and RadioGroup labelDirection consistent and fix label type error #497

Open
BeeMargarida opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@BeeMargarida
Copy link
Member

What package has an issue

@svelteuidev/core

A clear and concise description of what the bug is

  • The labelDirection default values for Radio and RadioGroup are different
  • There's an error with the label prop in RadioGroup, documented in this Discord support thread

In which browser(s) did the problem occur?

Firefox

Steps To Reproduce

Use this sample code: https://stackblitz.com/edit/sveltejs-kit-template-default-amdvqf?file=src%2Froutes%2F%2Bpage.svelte

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Relevant Assets

No response

@BeeMargarida BeeMargarida added the bug Something isn't working label Jun 24, 2024
@BeeMargarida
Copy link
Member Author

Label type error fixed in 3abcbfd, but the change in labelDirection is a breaking change, and will probably be addressed in the next version of the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant