Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make let: directive illegal when not used with slot #7101

Closed
iacore opened this issue Jan 5, 2022 · 2 comments
Closed

Make let: directive illegal when not used with slot #7101

iacore opened this issue Jan 5, 2022 · 2 comments

Comments

@iacore
Copy link

iacore commented Jan 5, 2022

Describe the bug

Currently, the compiler will accept let: directive on any element, no matter if it makes sense or not.

Reproduction

https://svelte.dev/repl/2a03fe9cfbd843aab96aa13e225dbfcc?version=3.44.3

Logs

No response

System Info

N/A

Severity

annoyance
@Prinzhorn
Copy link
Contributor

Yep, basically the main issue in #7084

But I think the compiler shouldn't compile let:value without slot, so I think this is a valid issue.

@Rich-Harris
Copy link
Member

In Svelte 5, slots are superseded by snippets, so it's not worth investing any more effort into validation around slots — will close this

@Rich-Harris Rich-Harris closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Prinzhorn @Rich-Harris @iacore