Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on empty aria- attributes #11323

Closed
Rich-Harris opened this issue Apr 24, 2024 · 0 comments · Fixed by #11325
Closed

Warn on empty aria- attributes #11323

Rich-Harris opened this issue Apr 24, 2024 · 0 comments · Fixed by #11325
Labels
Milestone

Comments

@Rich-Harris
Copy link
Member

Describe the problem

Svelte warns on this...

image

...but not on this, which is no more valid:

image

We're not 'fixing' things behind the scenes either — that'll become aria-hidden="", which is straightforwardly incorrect.

Describe the proposed solution

Stop treating empty aria-x attributes as equivalent to aria-x="true". They're not.

Importance

nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant