fix: correct redirection for examples/[...path] #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomoam is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
dummdidumm
reviewed
Jan 30, 2025
| @@ -1,5 +1,7 @@ | |||
| import { redirect } from '@sveltejs/kit'; | |||
|
|
|||
| export const prerender = false; | |||
There was a problem hiding this comment.
ah yea, that was missing, of course!
I'm wondering though if we should move it into the handle hook aswell and delete this file, because AFAIK all redirects happen inside handle right now.
There was a problem hiding this comment.
Thanks for the suggestion. For consistency, it does seem better to consolidate the redirects into the handle hook. I’ll update the PR to move the redirect logic there and remove the file accordingly.
There was a problem hiding this comment.
I’ve completed the changes. Please review at your convenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note on documentation PRs
If this is a documentation PR (i.e. changing content within
apps/svelte.dev/content/docs), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.fixes #1129 .
The following need to be checked on the preview site:
/examplesredirects to/playground/examples/hello-worldredirects to/playground/hello-world/examples/thumbnails/actions.jpgis not redirected