fix: const to let in "the <form> element" #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@golfomania is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
found more sections with the same code and changed it as well in second commit |
|
related to #543 |
|
I was just now working through the tutorial and bumped up against that problem. Thanks! |
|
@JonathanHarford as long as the PR is not accepted just fix it manually in the file 👍 |
|
Came here to fix this, happy to see you beat me to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lesson
The Form Element
Problem
In the load function in +page.server.js a new userid is created if not found in cookies
But id is declared as const so it can not be updated
Tutorial app run into 500 internal error
How to reproduce
e.g. open link in incognito window
Fix
change declaration from id from const to let
Martin
This is my first open source contribution, so i hope this PR works for you this way