Assign the ID back when creating a new userid in cookies #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This to make sure db.getTodos(id) isn't called with undefined, which is currently raising 500 errors when a user loads the tutorial page for the first time (subsequent requests will have a userID, so this is just a blib on the radar.
|
@HendrikPetertje is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
oops. sorry i canceled this! |
|
could this be reviewed? |
|
thanks! there's a few more places that need updating, so i'll close this in favour of #543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this amazing tutorial, it's so nice!
While following the tutorial I noticed that one excersise would cause a 500 to be rendered the first time the code was loaded, as I made just one change the page would re-render and all would be fine.
Upon looking closer I noticed that map get was being called with
undefined.This little change makes sure db.getTodos(id) isn't called with undefined.