From 58a705495daf52224902b2c7ee2a39510268bf3c Mon Sep 17 00:00:00 2001 From: Simon Holthausen Date: Mon, 7 Sep 2020 09:56:24 +0200 Subject: [PATCH 1/2] warn if old extension is installed --- packages/svelte-vscode/src/extension.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/svelte-vscode/src/extension.ts b/packages/svelte-vscode/src/extension.ts index e521a6174..d7f136c0d 100644 --- a/packages/svelte-vscode/src/extension.ts +++ b/packages/svelte-vscode/src/extension.ts @@ -12,6 +12,7 @@ import { ViewColumn, languages, IndentAction, + extensions, } from 'vscode'; import { LanguageClient, @@ -37,6 +38,8 @@ namespace TagCloseRequest { } export function activate(context: ExtensionContext) { + warnIfOldExtensionInstalled(); + const runtimeConfig = workspace.getConfiguration('svelte.language-server'); const { workspaceFolders } = workspace; @@ -307,3 +310,13 @@ function addExtracComponentCommand(getLS: () => LanguageClient, context: Extensi function createLanguageServer(serverOptions: ServerOptions, clientOptions: LanguageClientOptions) { return new LanguageClient('svelte', 'Svelte', serverOptions, clientOptions); } + +function warnIfOldExtensionInstalled() { + if (extensions.getExtension('JamesBirtles.svelte-vscode')) { + window.showWarningMessage( + 'It seems you have the old and deprecated Svelte extension installed. Please remove it. ' + + 'Through the UI: You can find it when searching for "@installed" in the extensions window (searching "Svelte" won\'t work). ' + + 'Command line: "code --uninstall-extension JamesBirtles.svelte-vscode"', + ); + } +} From 4eda0e3203f5bf6a9294c3d371f14135ee00b7dd Mon Sep 17 00:00:00 2001 From: Simon Holthausen Date: Mon, 7 Sep 2020 11:31:35 +0200 Subject: [PATCH 2/2] wording --- packages/svelte-vscode/src/extension.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/svelte-vscode/src/extension.ts b/packages/svelte-vscode/src/extension.ts index d7f136c0d..4d7be8992 100644 --- a/packages/svelte-vscode/src/extension.ts +++ b/packages/svelte-vscode/src/extension.ts @@ -314,7 +314,7 @@ function createLanguageServer(serverOptions: ServerOptions, clientOptions: Langu function warnIfOldExtensionInstalled() { if (extensions.getExtension('JamesBirtles.svelte-vscode')) { window.showWarningMessage( - 'It seems you have the old and deprecated Svelte extension installed. Please remove it. ' + + 'It seems you have the old and deprecated extension named "Svelte" installed. Please remove it. ' + 'Through the UI: You can find it when searching for "@installed" in the extensions window (searching "Svelte" won\'t work). ' + 'Command line: "code --uninstall-extension JamesBirtles.svelte-vscode"', );