Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source mapping is wrong when you comment out script #109

Closed
dummdidumm opened this issue May 22, 2020 · 1 comment
Closed

Source mapping is wrong when you comment out script #109

dummdidumm opened this issue May 22, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@dummdidumm
Copy link
Member

dummdidumm commented May 22, 2020

Describe the bug
Source mapping is wrong when you comment out script.

To Reproduce

Add "checkJs": true to jsconfig.json / tsconfig.json

<!-- <script>
const bla = true;

</script> -->

<Navigation />

Will do red ("cannot find Navigation") squiggels at script, not at Navigation.

Expected behavior
Everything should work the same as if script is not commented out

System (please complete the following information):

  • OS: Windows
  • IDE: VSCode
  • Plugin/Package: Svelte Beta

Additional context
Maybe that's something inside svelte2tsx, not honoring the comment and thinking there is a script tag.

@dummdidumm dummdidumm added the bug Something isn't working label May 22, 2020
@dummdidumm dummdidumm reopened this Jul 3, 2020
@dummdidumm
Copy link
Member Author

No longer reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant