fix: ensure isolated testing of create-svelte with local packages #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rich-Harris
approved these changes
Jul 14, 2022
|
this is amazing |
Rich-Harris
added a commit
that referenced
this pull request
Jul 14, 2022
* Upgrade to Vite 3 * this... seems to work? * try this * remove some more unneeded fixStacktrace options * upgrade to 3.0.0-beta.9 * update default port * 3.0.0 final * 3.0.0 final for site * vite-plugin-svelte 1.0.1 * bump rollup * update enforced_config * add EnforcedConfig type * wow i did a terrible job of implementing this before * leave windows paths as-is * Revert "leave windows paths as-is" This reverts commit 06de105. * try this * actually if anything i guess it should be this * ugh * fix firefox test * add some logging that might help diagnose windows failure * i think this might work * more logging * maybe this * try to simplify logging so that stuff is slightly easier to diagnose * argh * Revert "argh" This reverts commit 9e2d017. * Revert "try to simplify logging so that stuff is slightly easier to diagnose" This reverts commit 2a975ec. * [docs] add JSDocs for Vite build process * format * loop over values instead with `Object.values` * missed a closing bracket * fix: ensure isolated testing of create-svelte with local packages (#5524) * fix: move create-svelte test working dir out of pnpm workspae * fix: copy-paste error, adapter-auto override * fix: readd check command * fix: ensure that create-svelte tests generate test apps outside our main pnpm workspace * fix format * fix: readd --no-frozen-lockfile to override pnpm default when CI is true * remove logging * enforce vite 3 Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com> Co-authored-by: Dominik G <dominik.goepel@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for vite-3 branch, not master!
sets up a separate pnpm workspace and hard links local packages with absolute file paths via pnpm overrides
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0