[docs] add JSDocs for Vite build process #5517
Conversation
|
packages/kit/src/vite/index.js
Outdated
| for (const key of Object.keys(bundle)) { | ||
| // collect asset and output chunks | ||
| if (bundle[key].type === 'asset') { | ||
| assets.push(/** @type {import('rollup').OutputAsset} */ (bundle[key])); | ||
| } else { | ||
| chunks.push(/** @type {import('rollup').OutputChunk} */ (bundle[key])); | ||
| } | ||
| } |
There was a problem hiding this comment.
The key isn't used directly, might as well refactor it to Object.values while we're here.
There was a problem hiding this comment.
Yep, we can also leverage TS control flow for discriminated unions and remove the type assertion.
|
I merged this into |
Also refactored out a couple of methods to make
writeBundlea little shorter and moved a few log statements to better align with code boundaries