From 73a4371492665301f2c598ac4eae9840d329ffd7 Mon Sep 17 00:00:00 2001 From: Simon Holthausen Date: Fri, 23 Jun 2023 11:11:20 +0200 Subject: [PATCH] fix: ensure glob finds all files in folders For some reason {folders.value.join(',')} as part of the glob doesn't work and returns less files fixes #10228 --- .changeset/flat-berries-stare.md | 5 +++++ packages/migrate/migrations/svelte-4/index.js | 10 +++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 .changeset/flat-berries-stare.md diff --git a/.changeset/flat-berries-stare.md b/.changeset/flat-berries-stare.md new file mode 100644 index 000000000000..4711418d60b1 --- /dev/null +++ b/.changeset/flat-berries-stare.md @@ -0,0 +1,5 @@ +--- +'svelte-migrate': patch +--- + +fix: ensure glob finds all files in folders diff --git a/packages/migrate/migrations/svelte-4/index.js b/packages/migrate/migrations/svelte-4/index.js index e1223153c8f9..49cd16f7d0e3 100644 --- a/packages/migrate/migrations/svelte-4/index.js +++ b/packages/migrate/migrations/svelte-4/index.js @@ -67,9 +67,13 @@ export async function migrate() { '.svelte' ]; const extensions = [...svelte_extensions, '.ts', '.js']; - const files = glob(`{${folders.value.join(',')}}/**`, { filesOnly: true, dot: true }) - .map((file) => file.replace(/\\/g, '/')) - .filter((file) => !file.includes('/node_modules/')); + // For some reason {folders.value.join(',')} as part of the glob doesn't work and returns less files + const files = folders.value.flatMap( + /** @param {string} folder */ (folder) => + glob(`${folder}/**`, { filesOnly: true, dot: true }) + .map((file) => file.replace(/\\/g, '/')) + .filter((file) => !file.includes('/node_modules/')) + ); for (const file of files) { if (extensions.some((ext) => file.endsWith(ext))) {