Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration tool bombs out on sveltesociety.dev #6088

Closed
benmccann opened this issue Aug 19, 2022 · 0 comments · Fixed by #6096
Closed

Migration tool bombs out on sveltesociety.dev #6088

benmccann opened this issue Aug 19, 2022 · 0 comments · Fixed by #6096
Labels
bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Milestone

Comments

@benmccann
Copy link
Member

benmccann commented Aug 19, 2022

Describe the bug

I can't run the migration tool on the sveltesociety.dev repo

Reproduction

git clone git@github.com:svelte-society/sveltesociety.dev.git
cd sveltesociety.dev
git checkout staging
npm install
npx svelte-migrate routes

Logs

$ npx svelte-migrate routes
Need to install the following packages:
  svelte-migrate
Ok to proceed? (y) 

This will overwrite files in the current directory!

✔ Continue? … yes

file:/~/.npm/_npx/ca732f115159e57c/node_modules/svelte-migrate/migrations/routes/migrate_page_js/index.js:88
								: is_new(nodes.error, 'Error') && nodes.error.arguments[0].getText();
								                                                           ^

TypeError: Cannot read properties of undefined (reading 'getText')
    at file:/~/.npm/_npx/ca732f115159e57c/node_modules/svelte-migrate/migrations/routes/migrate_page_js/index.js:88:68
    at walk (file:/~/.npm/_npx/ca732f115159e57c/node_modules/svelte-migrate/migrations/routes/utils.js:373:5)

System Info

I upgraded to `@sveltejs/kit@1.0.0-next.405` already: https://github.com/svelte-society/sveltesociety.dev/commit/00536227b54d68cdd41e407e86fb6dfa30680f24

Severity

blocking an upgrade

Additional Information

No response

@benmccann benmccann added bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. labels Aug 19, 2022
@benmccann benmccann added this to the 1.0 milestone Aug 19, 2022
@dummdidumm dummdidumm mentioned this issue Aug 19, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant