@sveltejs/adapter-vercel not working anymore at vercel.com

[seppegadeyne]

Describe the bug

I have several SvelteKit websites hosted at vercel.com using @sveltejs/adapter-vercel. Since today (30/12/2021) deploys are not working anymore. If you run "npm run build" locally it works fine. Not on vercel itself.

Reproduction

Try to deploy on vercel.

Logs

No response

System Info

System:
    OS: Linux 5.11 Ubuntu 20.04.3 LTS (Focal Fossa)
    CPU: (16) x64 AMD Ryzen 9 5900HX with Radeon Graphics
    Memory: 42.46 GB / 62.71 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    npm: 8.1.4 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Chrome: 98.0.4758.9
  npmPackages:
    @glidejs/glide: ^3.5.2 => 3.5.2 
    @sveltejs/adapter-vercel: next => 1.0.0-next.32 
    @sveltejs/kit: next => 1.0.0-next.201 
    @tailwindcss/aspect-ratio: ^0.4.0 => 0.4.0 
    @tailwindcss/forms: ^0.4.0 => 0.4.0 
    @types/glidejs__glide: ^3.4.1 => 3.4.1 
    @typescript-eslint/eslint-plugin: ^4.31.1 => 4.33.0 
    @typescript-eslint/parser: ^4.31.1 => 4.33.0 
    autoprefixer: ^10.4.0 => 10.4.0 
    cssnano: ^5.0.6 => 5.0.12 
    eslint: ^7.32.0 => 7.32.0 
    eslint-plugin-svelte3: ^3.2.0 => 3.2.1 
    motion: ^10.4.0 => 10.4.0 
    postcss: ^8.4.5 => 8.4.5 
    postcss-load-config: ^3.1.0 => 3.1.0 
    sanitize-html: ^2.5.3 => 2.6.0 
    storyblok-js-client: ^4.1.5 => 4.1.5 
    svelte: ^3.38.2 => 3.44.2 
    svelte-check: ^2.2.6 => 2.2.10 
    svelte-preprocess: ^4.7.3 => 4.9.8 
    tailwind-scrollbar-hide: ^1.0.3 => 1.1.6 
    tailwindcss: ^3.0.2 => 3.0.2 
    tslib: ^2.3.1 => 2.3.1 
    typescript: ^4.5.2 => 4.5.2

Severity

blocking all usage of SvelteKit

Additional Information

No response

[seppegadeyne]

please check below....

[Rich-Harris]

Investigating

[Rich-Harris]

Can you try with @sveltejs/adapter-vercel@1.0.0-next.34?

[seppegadeyne]

same error message with version 34...

[HeritagePalms]

Can you try with @sveltejs/adapter-vercel@1.0.0-next.34?

This got me back in working order.

[Rich-Harris]

Oh, hang on — you're referencing $page.path. That won't work any more: #3126

The error that would have told you that is only printed in dev mode. Perhaps we should add it to prod mode too.

[Rich-Harris]

(Change $path.path to $page.url.pathname and $page.query to $page.url.searchParams, and the same for any uses of page.path and page.query in load functions, or request.path/request.query in endpoints)

[HeritagePalms]

(Change $path.path to $page.url.pathname and $page.query to $page.url.searchParams, and the same for any uses of page.path and page.query in load functions, or request.path/request.query in endpoints)

Even though it seems he is using older version? I for sure had to make this change on latest release but not on older ones.

@sveltejs/adapter-vercel: next => 1.0.0-next.32 
@sveltejs/kit: next => 1.0.0-next.201 

Nevermind, I just realised that with 'next' set, Vercel would get the latest version. So I guess he will have to stick with a specific version or make changes.

[Rich-Harris]

Even though it seems he is using older version?

In all likelihood a newer version is being installed on Vercel. This would explain why it works locally

[HeritagePalms]

Even though it seems he is using older version?

In all likelihood a newer version is being installed on Vercel. This would explain why it works locally

There i go thinking and typing at different timings...

[seppegadeyne]

url and params are not available in $app/stores like described in "...and the page store has been replaced with url and params stores" #3126

page store doesn't contain url see console.log ...

In dev mode all works fine like it used to be. Seems like the fresh npm install is not installing that version which is using the new stores....

[Rich-Harris]

Consult the docs, not the PR (things changed between the initial comment and what ended up getting shipped). You're looking for the page store

[Rich-Harris]

https://kit.svelte.dev/docs#modules-$app-stores

[seppegadeyne]

Now I can see it in dev mode too when I change "@sveltejs/kit": "next" to "@sveltejs/kit": "1.0.0-next.209". Bummer....

[Rich-Harris]

You should be getting an error message that tells you how to fix it?

[seppegadeyne]

Yes now it does when I put 1.0.0-next.209 version active :-) , with next version it's not.

[Rich-Harris]

next.209 is the next version (or at least it was, I just released next.210), you just weren't up to date locally. You should keep "next" in your package.json, otherwise you'll be stuck on 209 forever.

Looks like the issue is resolved — we okay to close this?

[netaisllc]

BTW, using simply next does render the error in the browser as well as the CLI...

Error: request.path has been replaced by request.url.pathname
    at Object.get (file:///Users/kevinm/Projects/Strongcloud/app-zero/node_modules/@sveltejs/kit/dist/ssr.js:1750:11)
    at Object.handle (//Users/kevinm/Projects/Strongcloud/app-zero/src/hooks:7:52)
    at respond (file:///Users/kevinm/Projects/Strongcloud/app-zero/node_modules/@sveltejs/kit/dist/ssr.js:1760:30)
    at svelteKitMiddleware (file:///Users/kevinm/Projects/Strongcloud/app-zero/node_modules/@sveltejs/kit/dist/chunks/index.js:4577:28)

[seppegadeyne]

@Rich-Harris yes okay to close. Thanks for the support. Best wishes for the New Year! ;-)