Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling prerendering breaks runtime on 1.0.0-next.208 using latest adapter-node #3141

Closed
pheuter opened this issue Dec 30, 2021 · 1 comment · Fixed by #3148
Closed

Disabling prerendering breaks runtime on 1.0.0-next.208 using latest adapter-node #3141

pheuter opened this issue Dec 30, 2021 · 1 comment · Fixed by #3148
Labels
bug Something isn't working
Milestone

Comments

@pheuter
Copy link

pheuter commented Dec 30, 2021

Describe the bug

Setting prerender: { enabled: false } in svelte.config.js causes svelte-kit build to no longer generate a build/prerendered directory, which throws this error during runtime:

Error: ENOENT: no such file or directory, scandir 'apps/v2/build/prerendered'
@careswitch/v2-app:preview:     at readdirSync (node:fs:1392:3)
@careswitch/v2-app:preview:     at list (file://apps/v2/build/handler-2aa2c439.js:57:12)

Reproduction

Any Svelte Kit app on 1.0.0-next.208 with @sveltejs/adapter-node: 1.0.0-next.57 and prerender: { enabled: false }, set in svelte.config.js.

Logs

No response

System Info

System:
    OS: macOS 12.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 5.05 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.3.0 - ~/.nvm/versions/node/v17.3.0/bin/node
    npm: 8.3.0 - ~/.nvm/versions/node/v17.3.0/bin/npm
  Browsers:
    Chrome: 96.0.4664.110
    Safari: 15.2
  npmPackages:
    @sveltejs/adapter-node: 1.0.0-next.57 => 1.0.0-next.57 
    @sveltejs/kit: 1.0.0-next.208 => 1.0.0-next.208 
    svelte: 3.44.3 => 3.44.3 

Severity

serious, but I can work around it

Additional Information

The workaround I'm currently doing is a manual mkdir -p build/prerendered after sveltekit build.

@benmccann
Copy link
Member

export const prerenderedMiddleware = fs.existsSync(paths.prerendered)

changed to

const serve_prerendered = sirv(path.join(__dirname, '/prerendered'), {

@benmccann benmccann added the bug Something isn't working label Dec 30, 2021
@benmccann benmccann added this to the 1.0 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants