Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a default adapter for the demo project #2459

Closed
penalosa opened this issue Sep 19, 2021 · 7 comments
Closed

Include a default adapter for the demo project #2459

penalosa opened this issue Sep 19, 2021 · 7 comments
Labels
p2-nice-to-have SvelteKit cannot be used by a small number of people, quality of life improvements, etc.

Comments

@penalosa
Copy link

Describe the problem

I installed the demo project and tried to build, but got an error mentioning that no adapter was specified, which seems somewhat confusing as a default experience.

Describe the proposed solution

Default the demo project to the static adapter/node adapter (not sure which is more appropriate), or add a question to the setup (along with whether to enable Typescript etc...) that defaults to including an adapter.

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

@Conduitry
Copy link
Member

I'm against adding a default. I'm ambivalent about adding an option to create-svelte. See #62 for the original discussion where we decided to not have a default adapter.

@penalosa
Copy link
Author

Sure, I get the reasoning behind not adding a default, but I think adding an option to create-svelte would really help first time users get started (or a bit more explanation to the "No adapter specified" warning message, something like "Adapters are how SvelteKit knows how to prepare your app for the specific platform you want to deploy to. See https://kit.svelte.dev/docs#adapters for a list of which adapters are available, and to learn how to configure your app to run on the platform of your choosing")

@benmccann
Copy link
Member

Adding it to create-svelte sounds fine to me if anyone wants to work on it

@benmccann benmccann added help wanted p2-nice-to-have SvelteKit cannot be used by a small number of people, quality of life improvements, etc. labels Sep 20, 2021
@Mlocik97
Copy link
Contributor

Mlocik97 commented Sep 21, 2021

related to: #2246

I mean it would be good to have option to add adapter in initializing project, but default should still be "I don't know yet / a different adapter". As dummdidumm wrote.

@ambarvm
Copy link
Contributor

ambarvm commented Sep 22, 2021

I'm interested in working on this.

@benmccann
Copy link
Member

Sounds fine to me. The default should probably be something like "Not now. I'll add it later or will use a community-provided adapter (https://bit.ly/3kvqIRy)"

Right now the list of community adapters at sveltesociety.dev is pre-rendered at build-time for that site. But we could probably send a PR to add an API endpoint to that site exposing the list of adapters. Then we could also allow you to choose from them as well

@Rich-Harris
Copy link
Member

This can be closed, both demo apps include adapter-auto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have SvelteKit cannot be used by a small number of people, quality of life improvements, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants