Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hero images to kit.svelte.dev #244

Closed
Rich-Harris opened this issue Dec 8, 2020 · 17 comments
Closed

Add hero images to kit.svelte.dev #244

Rich-Harris opened this issue Dec 8, 2020 · 17 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Rich-Harris
Copy link
Member

Includes #33, #34, #168, but I mostly wanted to raise this catch-all issue so we have a convenient place for @vedam's gorgeous work: https://www.figma.com/file/f87psJnCeqMbUPAQABmCrN/svelte

svelte-cutter-06
svelte-kit-04
svelte-kit-grey-05-small
svelte-liquid-08
svelte-main-10

@benmccann benmccann added the documentation Improvements or additions to documentation label Dec 11, 2020
@vedam
Copy link
Member

vedam commented Dec 14, 2020

OK,
I've refined things a bit more, especially a better OpenCollective-Render.
Updated figma-file
Maybe someone can tell me if you're able to comment on the figma-file?
First figma-experience, so I don't know if it's setup correctly.
I don't want to risk something going public until we're ready.

@Rich-Harris
Copy link
Member Author

These are looking better and better! I was able to add a comment

@vedam
Copy link
Member

vedam commented Dec 15, 2020

Great, then just comment if you have further need for action, criticism or suggestions for improvement.
It should even be possible to make a copy and move the elements around yourself to your like.
You see, svelte is also fun in areas you never thought of. 😄

@benmccann
Copy link
Member

I'm wondering where to integrate these. One idea would be in the three boxes on the SvelteKit homepage. "Powered by Svelte" could be the power plant looking thing, "Best of both worlds" could be the two streams colliding, "Build fast" could be the factory pumping out machines from boxes. Maybe the background of those three sections would change to the image when hovered over

@vedam
Copy link
Member

vedam commented Mar 18, 2021

Yes, when I made them I didn't know that SvelteKit would get its own site. IMO the illus are rather meant as a replacement for the relatively simple outline-S. Large background images as eyecandy (see figma-layout). One for Svelte itself and one for SvelteKit. As a result, the SvelteKit site is then also visually more distinct from the Svelte site. I think degrading them into the three boxes would make them very small-scale and petty after all.

[edit]
I updated the figma-file

@Rich-Harris
Copy link
Member Author

100%, definitely hero images. I absolutely love these mockups and can't wait for us to start implementing them

@benmccann
Copy link
Member

Oh, nice! Yeah, much better usage to have them more prominent! I just sort of thought it was funny how well the images matched the captions for the boxes and wasn't sure how to blend the backgrounds, but the Figma mockups look much better than what I suggested 😄

@benmccann benmccann changed the title kit.svelte.dev Add hero images to kit.svelte.dev Mar 23, 2021
@rodshtein
Copy link
Contributor

rodshtein commented Mar 24, 2021

Maybe someone can tell me if you're able to comment on the figma-file?
First figma-experience, so I don't know if it's setup correctly.
I don't want to risk something going public until we're ready.

@vedam Actually is already public
To make it private:

  1. First you need to make the file a private
    Screen Shot 2021-03-24 at 10 21 00 PM

  2. Then remove access from all non-team members
    Screen Shot 2021-03-24 at 10 23 38 PM

@vedam
Copy link
Member

vedam commented Mar 24, 2021

@zamkevich Thx for enlightening me.
I have now made the figma file accessible only to maintainers. If I have removed one of you from the viewlist accidentally (most likely because i can't assign the shown username), please let me know.
If you don't mind that the file is public, let me know too, and I'll reopen it again to everyone.

@MTyson
Copy link

MTyson commented Mar 24, 2021

I'd like to be able to see the files.

@benmccann
Copy link
Member

I have no issues with the files being public. It's up to @vedam whether he wants to be getting comments on them or not 😁

Anyway, the most interesting ones are already included in the description of this issue

@MTyson
Copy link

MTyson commented Mar 24, 2021

What is the license for these? Can we use them when promoting Svelte to the general public?
Just to repeat the obvious - they are really impressive.

@benmccann
Copy link
Member

See https://github.com/sveltejs/branding

@vedam
Copy link
Member

vedam commented Mar 25, 2021

OK then, if public viewing isn't a concern: reopened to view for everyone. ;-)

@simonlayfield
Copy link

Just seen these - really awesome work.

@benmccann
Copy link
Member

Making a note here for anyone that would want to work on this. The code lives in https://github.com/sveltejs/sites/tree/master/sites/kit.svelte.dev

@benmccann benmccann mentioned this issue Apr 9, 2021
1 task
@rafaelcamaram
Copy link
Contributor

rafaelcamaram commented Apr 13, 2021

I just created the first PR related to it: sveltejs/sites#17.

It's updating the existing components to match with the new design (adding the new hero image) -- I'll create a new PR in order to add the new sections soon :)

CC: @benmccann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

7 participants