From a57554403855fbb96350b9faeeea461f86eb3a4b Mon Sep 17 00:00:00 2001 From: Ignatius Bagus Date: Thu, 21 Oct 2021 16:48:29 +0700 Subject: [PATCH] [fix] add explicit types to examples (#2657) Fixes ESLint and TypeScript integration in _api.ts and form.ts example files Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> --- .changeset/poor-cameras-kick.md | 5 +++++ packages/create-svelte/templates/default/src/lib/form.ts | 4 ++-- .../templates/default/src/routes/todos/_api.ts | 8 ++++++-- 3 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 .changeset/poor-cameras-kick.md diff --git a/.changeset/poor-cameras-kick.md b/.changeset/poor-cameras-kick.md new file mode 100644 index 000000000000..60bd545ebc43 --- /dev/null +++ b/.changeset/poor-cameras-kick.md @@ -0,0 +1,5 @@ +--- +'create-svelte': patch +--- + +Add explicit types in `_api.ts` and `form.ts` for TypeScript and ESLint integration example diff --git a/packages/create-svelte/templates/default/src/lib/form.ts b/packages/create-svelte/templates/default/src/lib/form.ts index c52e92308830..67b6df704317 100644 --- a/packages/create-svelte/templates/default/src/lib/form.ts +++ b/packages/create-svelte/templates/default/src/lib/form.ts @@ -11,8 +11,8 @@ export function enhance( error?: (res: Response, error: Error, form: HTMLFormElement) => void; result: (res: Response, form: HTMLFormElement) => void; } -) { - let current_token: {}; +): { destroy: () => void } { + let current_token: unknown; async function handle_submit(e: Event) { const token = (current_token = {}); diff --git a/packages/create-svelte/templates/default/src/routes/todos/_api.ts b/packages/create-svelte/templates/default/src/routes/todos/_api.ts index 2319c187df76..2fd3385d1ed8 100644 --- a/packages/create-svelte/templates/default/src/routes/todos/_api.ts +++ b/packages/create-svelte/templates/default/src/routes/todos/_api.ts @@ -1,4 +1,4 @@ -import type { Request } from '@sveltejs/kit'; +import type { EndpointOutput, Request } from '@sveltejs/kit'; import type { Locals } from '$lib/types'; /* @@ -14,7 +14,11 @@ import type { Locals } from '$lib/types'; const base = 'https://api.svelte.dev'; -export async function api(request: Request, resource: string, data?: {}) { +export async function api( + request: Request, + resource: string, + data?: Record +): Promise { // user must have a cookie set if (!request.locals.userid) { return { status: 401 };