From a309d1c95b3f97f540a83f63f15399f0ff82a45f Mon Sep 17 00:00:00 2001 From: Frank Dumont Date: Wed, 17 May 2023 17:14:12 +0200 Subject: [PATCH] only cache response if response has cache-control header (#9885) * only cache response if response has cache-control header * add changeset --- .changeset/tidy-worms-reflect.md | 5 +++++ packages/adapter-cloudflare/src/worker.js | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .changeset/tidy-worms-reflect.md diff --git a/.changeset/tidy-worms-reflect.md b/.changeset/tidy-worms-reflect.md new file mode 100644 index 000000000000..f7d62b156e51 --- /dev/null +++ b/.changeset/tidy-worms-reflect.md @@ -0,0 +1,5 @@ +--- +'@sveltejs/adapter-cloudflare': patch +--- + +fix: require explicit cache-control header for caching diff --git a/packages/adapter-cloudflare/src/worker.js b/packages/adapter-cloudflare/src/worker.js index dcdcb9a46efb..6a421a4e9ba9 100644 --- a/packages/adapter-cloudflare/src/worker.js +++ b/packages/adapter-cloudflare/src/worker.js @@ -55,7 +55,8 @@ const worker = { // write to `Cache` only if response is not an error, // let `Cache.save` handle the Cache-Control and Vary headers - return res.status >= 400 ? res : Cache.save(req, res, context); + pragma = res.headers.get('cache-control') || ''; + return pragma && res.status < 400 ? Cache.save(req, res, context) : res; } };