Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack warning when using Angular 5 #79

Open
ottokruse opened this issue Dec 28, 2017 · 4 comments
Open

Webpack warning when using Angular 5 #79

ottokruse opened this issue Dec 28, 2017 · 4 comments

Comments

@ottokruse
Copy link

Up and running like a charm in Angular 5 without any alterations compared to our Angular 4 app, so that's great.

So it works, but .... webpack throws this warning message upon compilation.

Not sure if this issue belongs here or at Angular-CLI project (excuse me) but ng2-adal is mentioned in the stack trace.

WARNING in ./node_modules/ng2-adal/node_modules/@angular/core/@angular/core.es5.js
5675:15-102 Critical dependency: the request of a dependency is an expression
at ImportLazyContextDependency.getWarnings (C:\git\personen-app-ng5\node_modules\webpack\lib\dependencies\ContextDep
endency.js:39:18)
at Compilation.reportDependencyErrorsAndWarnings (C:\git\personen-app-ng5\node_modules\webpack\lib\Compilation.js:70
3:24)
at Compilation.finish (C:\git\personen-app-ng5\node_modules\webpack\lib\Compilation.js:561:9)
at applyPluginsParallel.err (C:\git\personen-app-ng5\node_modules\webpack\lib\Compiler.js:502:17)
at C:\git\personen-app-ng5\node_modules\tapable\lib\Tapable.js:289:11
at _addModuleChain (C:\git\personen-app-ng5\node_modules\webpack\lib\Compilation.js:507:11)
at processModuleDependencies.err (C:\git\personen-app-ng5\node_modules\webpack\lib\Compilation.js:477:14)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
@ ./node_modules/ng2-adal/node_modules/@angular/core/@angular/core.es5.js
@ ./node_modules/ng2-adal/dist/services/adal.service.js
@ ./node_modules/ng2-adal/dist/services.js
@ ./node_modules/ng2-adal/dist/core.js
@ ./src/app/app.module.ts
@ ./src/main.ts
@ multi webpack-dev-server/client?http://0.0.0.0:0 ./src/main.ts

@rjwijnen
Copy link

rjwijnen commented Jan 8, 2018

@savageqm
Copy link

Any timeline for possible release of this fix?

@jmtrz
Copy link

jmtrz commented Jun 28, 2018

Is this fixed alraedy? if yes how do we implement the fix?

@test0017
Copy link

I am using ng2-adal and its showing WARNING in ./node_modules/ng2-adal/node_modules/@angular/core/@angular/core.es5.js warning when i upgraded the application in to Angular5
I have tried adal-angular5 and do-adal-angular5 , Its working but calling ng-init 2 times .
Please let me know about it .
Thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants