Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enqueue-batch fails when command lines exceed 256k for one batch #29

Closed
ryanwitt opened this issue Mar 21, 2018 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@ryanwitt
Copy link
Member

ryanwitt commented Mar 21, 2018

Steps to reproduce

  1. Create a file with 10 lines, each command should be 100kb long

  2. Try to enqueue it

$ ./qdone enqueue-batch too-big.txt
Creating fail queue test_failed
Creating queue test
TypeError: Cannot read property 'Failed' of undefined
    at /Users/ryan/src/qdone-master/src/enqueue.js:128:17
    at _fulfilled (/Users/ryan/src/qdone-master/node_modules/q/q.js:854:54)
    at self.promiseDispatch.done (/Users/ryan/src/qdone-master/node_modules/q/q.js:883:30)
    at Promise.promise.promiseDispatch (/Users/ryan/src/qdone-master/node_modules/q/q.js:816:13)
    at /Users/ryan/src/qdone-master/node_modules/q/q.js:624:44
    at runSingle (/Users/ryan/src/qdone-master/node_modules/q/q.js:137:13)
    at flush (/Users/ryan/src/qdone-master/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickDomainCallback (internal/process/next_tick.js:128:9)
bash: update_terminal_cwd: command not found

Expected behavior

Large command lines should enqueue in an appropriate number of api calls (2 commands per api call, in this test case).

@ryanwitt ryanwitt added the bug label Mar 21, 2018
@ryanwitt ryanwitt added this to the v1.3.0 milestone Mar 21, 2018
@ryanwitt ryanwitt self-assigned this Mar 21, 2018
@ryanwitt
Copy link
Member Author

Test case:

too-big.txt

@ryanwitt ryanwitt mentioned this issue Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant