Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwt parser not accounting for clock skew #362

Closed
dInquisitor opened this issue Sep 12, 2023 · 3 comments
Closed

jwt parser not accounting for clock skew #362

dInquisitor opened this issue Sep 12, 2023 · 3 comments

Comments

@dInquisitor
Copy link

When testing out the supertokens exploratory project, I kept getting a "Token used before issued" error with Google sign in/up.
It turns out that the version of the golang-jwt package (v4) being used for oauth claims validation does not account for clock skew between my server and IdP server which caused the oauth token to be apparently issued 1 second after it's used here.

The current version (v5) now accounts for clock skew, so is it possible to consider upgrading to the new version?
The only dependency seems to be keyfunc, which also only needs a version bump as far as I can tell.

@nkshah2
Copy link
Contributor

nkshah2 commented Sep 12, 2023

Hi @dInquisitor

Thanks for the issue! The migration guide for golang-jwt seems pretty extensive so we will need time to evaluate all the changes needed and possible side effects of moving to v5. We will add it to our pipeline and get around to this as soon as we can. Leaving this open so you can keep track of progress on this

@dInquisitor
Copy link
Author

thank you!

@rishabhpoddar
Copy link
Contributor

This has been released in version >= 0.16.0 of the golang SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants