Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] permit JPEG logos #965

Closed
mirabilos opened this issue Nov 6, 2022 · 1 comment · Fixed by #973
Closed

[feature] permit JPEG logos #965

mirabilos opened this issue Nov 6, 2022 · 1 comment · Fixed by #973
Labels
enhancement New feature or request

Comments

@mirabilos
Copy link
Contributor

Is your feature request related to a problem ?

I’ve found that the header template is not the only place where the server logo is referenced; /assets/logo.png is also hard-coded in the binary somewhere.

This is a bit frustrating because my server’s intended logo is ½ MiB in PNG but less than a tenth of that as JPEG.

Describe the solution you'd like.

Make the path configurable, so I can put a JPEG file in there and don’t need to overwrite the stock logo.png file either.

Ideally, let the template also read that path, so I don’t need to change it. (Bonus: add a second setting for the alt text, so I can put the CC attribution notice there, then I really don’t need to modify the template file.)

Describe alternatives you've considered.

Well I overwrote the logo.png file now, but that’s ofc slower / higher traffic.

Additional context.

No response

@mirabilos mirabilos added the enhancement New feature or request label Nov 6, 2022
@tsmethurst
Copy link
Contributor

Good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants