Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Environment variable to toggle TLS for s3 backend #1293

Closed
lsnow99 opened this issue Jan 3, 2023 · 5 comments · Fixed by #1294
Closed

[feature] Environment variable to toggle TLS for s3 backend #1293

lsnow99 opened this issue Jan 3, 2023 · 5 comments · Fixed by #1294
Labels
enhancement New feature or request

Comments

@lsnow99
Copy link
Contributor

lsnow99 commented Jan 3, 2023

Is your feature request related to a problem ?

I run Minio within my LAN only, and do not have a TLS certificate configured for it. If I try to use it as the S3 backend, I get an error that a non-HTTPS response was provided.

Describe the solution you'd like.

I think it should be possible to toggle TLS for the S3 backend via an environment variable.

Describe alternatives you've considered.

Using a custom certificate is my best option, but I would prefer to be able to use Minio over HTTP.

Additional context.

No response

@lsnow99 lsnow99 added the enhancement New feature or request label Jan 3, 2023
@lsnow99 lsnow99 mentioned this issue Jan 3, 2023
9 tasks
@lsnow99
Copy link
Contributor Author

lsnow99 commented Jan 3, 2023

Update: It turns out there already is a variable for this, it just wasn't in the documentation. #1294 adds a note about it.

@chenzhiwei
Copy link

Seems gotosocial will use the S3 endpoint to expose the media address, the browser will show insure connection.

@igalic
Copy link
Contributor

igalic commented Jan 7, 2023

that seems like bad form either way:
the end point could be private, like it is here.
or it could be poorly configured, like (not) suggested here #1300

@lsnow99
Copy link
Contributor Author

lsnow99 commented Jan 7, 2023

Yeah my s3 server is not publicly accessible, so I am using this option in conjunction with storage-s3-proxy set to true

@chenzhiwei
Copy link

I have a VPS and initially use local storage, later I setup a Minio instance, but seems there is no obvious benefits storing media files in to a Minio instance in a single VPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants