Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug/0.6.0-rc1] Profile settings css issues in Safari #1175

Closed
Fastidious opened this issue Nov 29, 2022 · 12 comments · Fixed by #1193
Closed

[bug/0.6.0-rc1] Profile settings css issues in Safari #1175

Fastidious opened this issue Nov 29, 2022 · 12 comments · Fixed by #1193
Labels
bug Something isn't working frontend Frontend-related stuff

Comments

@Fastidious
Copy link

Describe the bug with a clear and concise description of what the bug is.

The profile screen has UX issues. See:

Screenshot 2022-11-29 at 10 46 14

What's your GoToSocial Version?

v0.6.0-rc1

GoToSocial Arch

amd64

Browser version

No response

What happened?

Went to profile, saw screen as above

What you expected to happen?

I expected to see a profile screen that allowed me to upload avatar and banner images.

How to reproduce it?

Go to https://instance/user.

Anything else we need to know?

No response

@Fastidious Fastidious added the bug Something isn't working label Nov 29, 2022
@Fastidious Fastidious changed the title [bug] Profile broken [bug/v0.6.0-rc1] Profile broken Nov 29, 2022
@Fastidious Fastidious changed the title [bug/v0.6.0-rc1] Profile broken [bug/0.6.0-rc1] Profile broken Nov 29, 2022
@tsmethurst
Copy link
Contributor

This looks like you only did a partial update of the frontend assets. Are you running with docker, or the tarred binary/assets? If the latter, make sure you untar all the assets/css properly + replace any existing css/js files with the new ones.

@Fastidious
Copy link
Author

Fastidious commented Nov 29, 2022

@tsmethurst I am using the tar.gz. I deleted the working web directory, and copied over the one from the tarball. Still the same issue. Flushed browser's cache, still the same issue.

@tsmethurst
Copy link
Contributor

hmm, which browser are you using?

@Fastidious
Copy link
Author

Found the bug! It only happens on Safari.

@tsmethurst
Copy link
Contributor

It only happens on Safari.

alright :) will try to get a fix in before the release proper, thanks!

@tsmethurst tsmethurst changed the title [bug/0.6.0-rc1] Profile broken [bug/0.6.0-rc1] Profile settings css issues in Safari Nov 29, 2022
@tsmethurst tsmethurst added the frontend Frontend-related stuff label Nov 29, 2022
@kingmath
Copy link

Same issue with Safari in iOS 15.7.1.
Screen was photographed in two parts.

IMG_0164

IMG_0165

@po5
Copy link

po5 commented Nov 30, 2022

I experienced issues on my instance too. The issue is that the css from the previous version is cached.
Everything is fine for existing users after a hard reload, and for new users by default.
We should use the software version as a query string to break browser's cache when updating.

@Fastidious
Copy link
Author

@po5 when it happened to me, I tried it on a different browser (that was never used to access my instance), and even tried on incognito mode. Still same results. I don't think it is what you think it is.

@f0x52
Copy link
Contributor

f0x52 commented Dec 1, 2022

@Fastidious there's some suspicion it might still be caching, could you check the devtools to see if it's a cached response?

@f0x52
Copy link
Contributor

f0x52 commented Dec 1, 2022

update: I can reproduce the issue in Epiphany, so it's not caching related

@joepie91
Copy link

joepie91 commented Dec 1, 2022

This should probably be reported to https://webcompat.com/

@Fastidious
Copy link
Author

@tsmethurst waiting for this to make it to an RC, because I can’t see the /admin settings neither, on Safari (they show fine under Chrome). #1193 might fix it, but no way to test it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants