-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support react-redux v7 #287
Comments
I am waiting for this as well - thank you for opening this. connected-react-router/package.json Line 39 in a8e92e6
|
I tested and it seems like it's not backward compatible. I had no time to look through it yet, but, I think it may be related to the way it changed the subscription back from Context API to direct subscription (See #191 when it changed from direct subscription to Context API). I'll take a look during the weekend. In the meantime, PR is welcome. |
I upgraded to react-redux v7 and it seemed to work fine for me:
|
@supasate First thanks for the work you put into connected-react-router. Really helpful ! For information, looks it works for me with react-redux 7. Sorry I could not go deeper in the internal changes. Seems too complex for me ;) Thx again for great work, it's appreciated |
It is working for me with react-redux 7.0.2 |
I've created a PR to allow react-redux@7. However, passing a custom context does not currently work: #303 |
My fix for react-redux has been merged in reduxjs/react-redux#1278 and #303 will be ready once a new version of react-redux is released. |
It seem that react-redux has published new version |
Released in v6.5.0. |
Hi @supasate, Today I upgrade router related packages in my project after that, I am getting 2 errors while running the project. Packages which are updated from and to versions
The error which I am getting
Please let me know how to fix these 2 issues. |
The same issue here. Any updates yet? |
@BiosBoy How can developers recreate the bug on their end? Please create a new issue and provide repro steps, include a copy of your code (or create a repro repository) and the full output of your run. Otherwise there's nothing to work on. |
I'm having the same problem. @prepaka did you find a solution? |
v7 just came out: https://github.com/reduxjs/react-redux/releases/tag/v7.0.1
Currently we're tied to v6:
connected-react-router/package.json
Line 38 in a8e92e6
The text was updated successfully, but these errors were encountered: