Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return object id on object operations #197

Closed
wants to merge 1 commit into from

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Sep 30, 2022

What kind of change does this PR introduce?

feature

What is the current behavior?

currently is not possible to create relationships from the client side to an object because the id is never returned

What is the new behavior?

object id is returned on the following operations:

  • createObject
  • copyObject
  • updateObject

@fenos fenos force-pushed the feat/return-object-id branch from dfd56fd to 185b131 Compare September 30, 2022 14:47
@fenos fenos force-pushed the feat/return-object-id branch from 185b131 to 27d81a2 Compare September 30, 2022 14:56
@coveralls
Copy link

coveralls commented Sep 30, 2022

Pull Request Test Coverage Report for Build 3159680588

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 29 of 29 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.818%

Totals Coverage Status
Change from base Build 3157262546: 0.02%
Covered Lines: 2906
Relevant Lines: 3340

💛 - Coveralls

Key: { type: 'string', examples: ['folder/destination.png'] },
},
required: ['Key'],
required: ['Key', 'Id'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change it to id. Key is the only place we use capital case - we should change that to key in the next breaking release

@groud
Copy link

groud commented Nov 30, 2022

Hello!

We are using supabase on our project and we would need the ID returned somehow, or at least a way to get it using an API endpoint. I've just found this PR would likely solve our issue and I was wondering if it was planned to merge it (once rebased), or if another solution is planned to be provided soon ?

@fenos
Copy link
Contributor Author

fenos commented May 22, 2023

This is now been implemented by #332

@fenos fenos closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants