fix: add get, head and count parameters to the rpc method. #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
| @@ -78,12 +80,22 @@ def from_table(self, table: str) -> AsyncRequestBuilder: | |||
| """Alias to :meth:`from_`.""" | |||
| return self.from_(table) | |||
|
|
|||
| def rpc(self, func: str, params: dict) -> AsyncRPCFilterRequestBuilder[Any]: | |||
| def rpc( | |||
| self, | |||
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Move setting of default value for variable into
elsebranch (introduce-default-else) - Split conditional into multiple branches [×2] (
split-or-ifs) - Merge duplicate blocks in conditional [×2] (
merge-duplicate-blocks) - Remove redundant conditional [×2] (
remove-redundant-if)
| @@ -78,12 +80,22 @@ def from_table(self, table: str) -> SyncRequestBuilder: | |||
| """Alias to :meth:`from_`.""" | |||
| return self.from_(table) | |||
|
|
|||
| def rpc(self, func: str, params: dict) -> SyncRPCFilterRequestBuilder[Any]: | |||
| def rpc( | |||
| self, | |||
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Move setting of default value for variable into
elsebranch (introduce-default-else) - Split conditional into multiple branches [×2] (
split-or-ifs) - Merge duplicate blocks in conditional [×2] (
merge-duplicate-blocks) - Remove redundant conditional [×2] (
remove-redundant-if)
silentworks
changed the title
J0
reviewed
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature update
What is the current behavior?
You can't perform get, head or count on a rpc method
What is the new behavior?
You can perform get, head or count on a rpc method
Additional context
Add any other context or screenshots.