Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use account linking algorithm #829

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Conversation

hf
Copy link
Contributor

@hf hf commented Nov 21, 2022

Uses the account linking algorithm described in #792 for linking accounts via external identities. This change produces equivalent results as the previous algorithm, while also supporting the SSO case.

(Depends on #826.)

@hf hf requested a review from a team as a code owner November 21, 2022 17:53
@hf hf force-pushed the hf/use-account-linking-algorithm branch 4 times, most recently from a9b5b9e to cabeb01 Compare November 21, 2022 18:16
@kangmingtay kangmingtay changed the base branch from master to hf/add-identities-email-is-duplicate-lookup November 24, 2022 00:35
@kangmingtay kangmingtay changed the base branch from hf/add-identities-email-is-duplicate-lookup to master November 24, 2022 00:36
Copy link
Member

@kangmingtay kangmingtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm!

api/external.go Show resolved Hide resolved
models/linking.go Show resolved Hide resolved
models/user.go Show resolved Hide resolved
@hf hf force-pushed the hf/use-account-linking-algorithm branch from cabeb01 to d9f4291 Compare November 24, 2022 16:30
@hf hf requested a review from kangmingtay November 24, 2022 16:40
@hf hf merged commit c709ed5 into master Nov 25, 2022
@hf hf deleted the hf/use-account-linking-algorithm branch November 25, 2022 14:44
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
Uses the account linking algorithm described in supabase#792 for linking
accounts via external identities. This change produces equivalent
results as the previous algorithm, while also supporting the SSO case.

(Depends on supabase#826.)
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
Uses the account linking algorithm described in supabase#792 for linking
accounts via external identities. This change produces equivalent
results as the previous algorithm, while also supporting the SSO case.

(Depends on supabase#826.)
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
Uses the account linking algorithm described in supabase#792 for linking
accounts via external identities. This change produces equivalent
results as the previous algorithm, while also supporting the SSO case.

(Depends on supabase#826.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants