feat: update oauth1.a flow #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Jan 19, 2024
|
🎉 This PR is included in version 2.138.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 task
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Previously, we needed to check if the request token generated matches the oauth token returned in the callback to prevent replay attacks. * However, this is mitigated by verifying the `state` jwt query param on the callback. * The [oauth1.a spec](https://oauth.net/core/1.0a/#auth_step1) also doesn't mention that the consumer needs to verify that the request token matches the oauth token returned in the callback * This also fixes issues where the `_gotrue_session` cookie is not being sent on the callback, which results in "session could not be found for this request" error.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Previously, we needed to check if the request token generated matches the oauth token returned in the callback to prevent replay attacks. * However, this is mitigated by verifying the `state` jwt query param on the callback. * The [oauth1.a spec](https://oauth.net/core/1.0a/#auth_step1) also doesn't mention that the consumer needs to verify that the request token matches the oauth token returned in the callback * This also fixes issues where the `_gotrue_session` cookie is not being sent on the callback, which results in "session could not be found for this request" error.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? * Previously, we needed to check if the request token generated matches the oauth token returned in the callback to prevent replay attacks. * However, this is mitigated by verifying the `state` jwt query param on the callback. * The [oauth1.a spec](https://oauth.net/core/1.0a/#auth_step1) also doesn't mention that the consumer needs to verify that the request token matches the oauth token returned in the callback * This also fixes issues where the `_gotrue_session` cookie is not being sent on the callback, which results in "session could not be found for this request" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
statejwt query param on the callback._gotrue_sessioncookie is not being sent on the callback, which results in "session could not be found for this request" error.